Skip to content

[io] consistently use TNetXNGFile ^[x]?root[s]?:// URLs#22744

Merged
jblomer merged 1 commit into
root-project:masterfrom
jblomer:io-fix-roots-plugin
Jul 3, 2026
Merged

[io] consistently use TNetXNGFile ^[x]?root[s]?:// URLs#22744
jblomer merged 1 commit into
root-project:masterfrom
jblomer:io-fix-roots-plugin

Conversation

@jblomer

@jblomer jblomer commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Make sure that

  • RRawFile uses TNetXNGFile for xroot:// and xroots:// URLs (and not only root://, roots://)
  • TFile uses TNetXNGFile for roots:// and xroots:// URLs (and not only root://, xroot://)

@jblomer jblomer self-assigned this Jul 2, 2026
@jblomer jblomer requested a review from dpiparo as a code owner July 2, 2026 12:06
@jblomer jblomer added the in:I/O label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 15h 57m 3s ⏱️
 3 874 tests  3 851 ✅ 0 💤 23 ❌
79 700 runs  79 677 ✅ 0 💤 23 ❌

For more details on these failures, see this check.

Results for commit 9731d71.

@dpiparo dpiparo added the experiment Affects an experiment / reported by its software & computimng experts label Jul 2, 2026
@dpiparo

dpiparo commented Jul 2, 2026

Copy link
Copy Markdown
Member

If @jblomer agrees, I would propose to backport at least to 6.40 once merged.

@jblomer jblomer merged commit 4556f1c into root-project:master Jul 3, 2026
37 of 42 checks passed
@jblomer jblomer deleted the io-fix-roots-plugin branch July 3, 2026 09:13
@jblomer

jblomer commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport 6.40

@jblomer

jblomer commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to 6.40

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #22744 to branch 6.40 requested by jblomer

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22752

@smuzaffar

Copy link
Copy Markdown
Contributor

@jblomer , looks like, with this change, now in cmssw we ended up using root's TNetXNGFile plugin instead of our storage factor adeptor ( cms-sw/cmsdist#10706 (comment) ). We do want to use our TStorageFactoryFile for root:// . So what is the correct way to configure root to use our TStorageFactoryFile for root://?

smuzaffar added a commit to smuzaffar/cmssw that referenced this pull request Jul 7, 2026
smuzaffar added a commit to smuzaffar/cmssw that referenced this pull request Jul 7, 2026
smuzaffar added a commit to smuzaffar/cmssw that referenced this pull request Jul 7, 2026
smuzaffar added a commit to smuzaffar/cmssw that referenced this pull request Jul 7, 2026
cmsbuild added a commit to cms-sw/cmssw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment Affects an experiment / reported by its software & computimng experts in:I/O

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants